🤖 Re-apply PR #382: Move Files Changed to top and remove stickiness #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original PR #382 was accidentally lost during the Tailwind v4 migration (commit 7e7d5c71b79). This commit re-applies those changes to the current Tailwind-based codebase. Changes: - Search bar moved outside scrollable area (always visible at top) - Created single scrollable container for file tree + hunks - File tree now at top in all viewports (not side-by-side) - File tree no longer sticky - scrolls away naturally with content Layout: - Search bar: Fixed at top - ScrollableContent: Single overflow-y-auto container - FileTree: First child, sizes to content (flex-[0_0_auto]) - Hunks: Below file tree, sizes to content Fixes: File tree remaining visible when scrolling through hunks
ammar-agent
force-pushed
the
review-fixes-reapply
branch
from
7354156 to
a10db0b
Compare
Added explicit instruction to never close PRs without user direction. Agents should always force-push to existing branches instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #382 was merged but was accidentally reverted by commit
00e5b179(🤖 Restore ReviewPanel and FileTree from good state) during the Tailwind migration. This PR re-applies those changes to the current Tailwind-based codebase.Changes
Layout Restructuring
overflow-y-autodiv containing both file tree and hunksTechnical Implementation
border-bflex min-h-0 flex-1 flex-col overflow-y-autoflex-[0_0_auto](sizes to content, doesn't grow)flex-[0_0_auto](sizes to content)Before vs After
Before (reverted state):
After (this PR):
Related
00e5b179(Tailwind migration cleanup)Generated with
cmux